Enable deprecation error for v1.17.0 #18341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delvh
approved these changes
Jan 20, 2022
GiteaBot
added
the
lgtm/need 1
|
Do we really need these two logs? I prefer to only output one error log. |
Not sure, both messages are important. But I think it can be merged into 1 bigger message. |
Codecov Report
@@ Coverage Diff @@
## main #18341 +/- ##
==========================================
+ Coverage 46.10% 46.11% +0.01%
==========================================
Files 837 837
Lines 92331 92332 +1
==========================================
+ Hits 42566 42579 +13
+ Misses 43004 42993 -11
+ Partials 6761 6760 -1
Continue to review full report at Codecov.
|
|
we got anymore of these? |
|
Not that I can find, or they are worded differently. |
|
yup we got a few... let me add some code. |
zeripath
reviewed
Jan 20, 2022
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
the
type/refactoring
Do some more deprecations and add common comment // FIXME: DEPRECATION
zeripath
approved these changes
Jan 20, 2022
GiteaBot
added
lgtm/done
6543
approved these changes
Jan 20, 2022
Closed
zjjhot
pushed a commit
to zjjhot/gitea
that referenced
this pull request
Jan 21, 2022
* giteaoffical/main: [skip ci] Updated translations via Crowdin Refactor jwt.StandardClaims to RegisteredClaims (go-gitea#18344) format with gofumpt (go-gitea#18184) Enable deprecation error for v1.17.0 (go-gitea#18341) Use correct translation key for errors (go-gitea#18342) Refactor Router Logger (go-gitea#17308) Updated Chroma to v0.10.0 (go-gitea#18270)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Co-authored-by: Andrew Thornton <art27@cantab.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title
Introduced in #16957 by @6543