Webauthn nits #18284
Merged
Webauthn nits #18284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
added
type/bug
skip-changelog
6543
reviewed
Jan 15, 2022
GiteaBot
added
the
lgtm/need 2
6543
reviewed
Jan 15, 2022
wxiaoguang
reviewed
Jan 15, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
reviewed
Jan 15, 2022
zeripath
commented
Jan 15, 2022
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
wxiaoguang
reviewed
Jan 15, 2022
wxiaoguang
approved these changes
Jan 15, 2022
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## main #18284 +/- ##
=======================================
Coverage 45.74% 45.74%
=======================================
Files 831 831
Lines 92164 92165 +1
=======================================
+ Hits 42159 42163 +4
- Misses 43244 43245 +1
+ Partials 6761 6757 -4
Continue to review full report at Codecov.
|
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
6543
approved these changes
Jan 15, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 17, 2022
* 'main' of https://github.com/go-gitea/gitea: show pull link for agit pull request also (go-gitea#18235) [skip ci] Updated translations via Crowdin Add some .ignore entries (go-gitea#18296) Remove unneeded debug messages to stdout. (go-gitea#18298) Handle missing default branch better in owner/repo/branches page (go-gitea#18290) Revert "Prevent possible XSS when using jQuery (go-gitea#18289)" (go-gitea#18293) not show double error response in git hook (go-gitea#18292) Remove accidental debugging in blob_excerpt.tmpl (go-gitea#18287) Prevent possible XSS when using jQuery (go-gitea#18289) Return nicer error if trying to pull from non-existent user (go-gitea#18288) [skip ci] Updated translations via Crowdin docs: mention client_max_body_size affects LFS (go-gitea#18291) Add lockfile-check (go-gitea#18285) Webauthn nits (go-gitea#18284)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
This contains some additional fixes and small nits related to go-gitea#17957 Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: 6543 <6543@obermui.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some additional fixes and small nits related to #17957