Fix documents for development and bug report #18249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Jan 12, 2022
GiteaBot
added
the
lgtm/need 1
delvh
reviewed
Jan 12, 2022
|
|
||
| You should format your code with `go fmt` using: | ||
| You should format your code: |
There was a problem hiding this comment.
Suggested change
| You should format your code: | |
| You should format your code using |
There was a problem hiding this comment.
The original text is better.
|
|
||
| ```bash | ||
| make fmt | ||
| ``` | ||
|
|
||
| and can test whether your changes would match the results with: | ||
| and lint the source code: |
There was a problem hiding this comment.
Suggested change
| and lint the source code: | |
| and lint it using |
There was a problem hiding this comment.
The original text is better.
singuliere
approved these changes
Jan 12, 2022
GiteaBot
added
lgtm/done
|
The test failure is unrelated.
|
delvh
approved these changes
Jan 12, 2022
Codecov Report
@@ Coverage Diff @@
## main #18249 +/- ##
=======================================
Coverage 45.59% 45.59%
=======================================
Files 830 830
Lines 92089 92089
=======================================
+ Hits 41987 41990 +3
+ Misses 43361 43354 -7
- Partials 6741 6745 +4
Continue to review full report at Codecov.
|
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 13, 2022
* giteaoffical/main: Fix documents for development and bug report (go-gitea#18249) Add/update SMTP auth providers via cli (go-gitea#18197) Fix NPE on try to get tag reference via API (go-gitea#18245) Fix update user bug (go-gitea#18250)
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some documents and sentences.
Make sure you are using the latest releasebefore submitting an issue.hacking-on-gitea.en-us.mdto tell developers to do lint correctly.make fmt-checkHopefully we can keep documents correct and up-dated.