Fix invalid reference in feeds template #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DblK
reviewed
May 26, 2017
models/action.go
Outdated
| @@ -142,6 +142,11 @@ func (a *Action) ShortActUserName() string { | |||
| return base.EllipsisString(a.GetActUserName(), 20) | |||
| } | |||
|
|
|||
| func (a *Action) GetActAvatar() string { | |||
There was a problem hiding this comment.
Good catch, updated
|
maybe add an integration test for the dashboard so that any template render error could be catched next time. @ethantkoenig |
tboerger
added
the
lgtm/need 2
|
Otherwise LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
May 27, 2017
|
LGTM |
tboerger
added
lgtm/done
|
@lunny Added an integration test |
ethantkoenig
force-pushed
the
fix_template
branch
from
bced2d3
to
f8a7065
Compare
|
Rebased to get update to Immediately after rebasing, I realized that it wasn't necessary, since a bad signature won't break a PR build. Sorry for any inconvenience. |
|
@ethantkoenig don't worry, I will merge this after CI completed. |
|
Hi Thanks I tested now and no problem on dashboard display |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error on the dashboard page: (oversight on my part from #1779)
see #1812 (comment)