Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update xgo to use 1.17 #17915

Merged
merged 2 commits into from
Dec 6, 2021
Merged

update xgo to use 1.17 #17915

merged 2 commits into from
Dec 6, 2021

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 5, 2021
@techknowlogick techknowlogick added this to the 1.16.0 milestone Dec 5, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 6, 2021
@techknowlogick techknowlogick merged commit 6255ff8 into main Dec 6, 2021
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch December 6, 2021 00:48
@wxiaoguang
Copy link
Contributor

Can we drop go 1.16 now? If yes, some code (like IsIPPrivate) can be rewritten to use go 1.17 features.

@lunny
Copy link
Member

lunny commented Dec 6, 2021

I think we can do that after we create 1.16 branch.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@techknowlogick
update xgo to use 1.17 (go-gitea#17915)
cd8f020
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@techknowlogick @wxiaoguang @lunny @6543 @delvh @GiteaBot