Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: modules do not rely on models, services do #17861

Merged
merged 1 commit into from Nov 30, 2021

Conversation

singuliere
Copy link
Contributor

According to @wxiaoguang and @zeripath:

services: provide some services for users, usually use
database (models) modules: provide some basic functions without
database, eg: code parser, etc The major difference is services use
database, while modules don’t.

See also https://discourse.gitea.io/t/difference-between-services-and-modules/4101/2?u=singuliere

According to @wxiaoguang and @zeripath:

services: provide some services for users, usually use
database (models) modules: provide some basic functions without
database, eg: code parser, etc The major difference is services use
database, while modules don’t.

Signed-off-by: singuliere <singuliere@autistici.org>
@codecov-commenter
Copy link

Codecov Report

Merging #17861 (b777705) into main (9ecfc54) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17861      +/-   ##
==========================================
- Coverage   45.53%   45.53%   -0.01%     
==========================================
  Files         809      809              
  Lines       90059    90059              
==========================================
- Hits        41010    41004       -6     
- Misses      42494    42501       +7     
+ Partials     6555     6554       -1     
Impacted Files Coverage Δ
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
modules/queue/workerpool.go 48.09% <0.00%> (-1.91%) ⬇️
models/issue_comment.go 52.40% <0.00%> (-0.57%) ⬇️
routers/api/v1/repo/pull.go 28.83% <0.00%> (-0.52%) ⬇️
services/pull/pull.go 41.78% <0.00%> (ø)
modules/queue/queue_bytefifo.go 59.88% <0.00%> (+0.59%) ⬆️
models/repo_list.go 79.20% <0.00%> (+0.79%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ecfc54...b777705. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 30, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 30, 2021
@lunny lunny added the type/docs This PR mainly updates/creates documentation label Nov 30, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2021
@zeripath zeripath merged commit 64b7d0d into go-gitea:main Nov 30, 2021
@singuliere singuliere deleted the wip-docs-backend branch November 30, 2021 12:19
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
services: provide some services for users, usually use
database (models) modules: provide some basic functions without
database, eg: code parser, etc The major difference is services use
database, while modules don’t.

Signed-off-by: singuliere <singuliere@autistici.org>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants