Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test cache during init #17852

Merged
merged 5 commits into from
Dec 5, 2021
Merged

Test cache during init #17852

merged 5 commits into from
Dec 5, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 29, 2021 •
edited

Some users set wrong options for cache. Such mistake can not be easily found before the cache is accessed.

Now we check if the cache works during init, the error can be reported as early as possible (just like incorrect database config would fail the init)

Close or relate:

@wxiaoguang wxiaoguang added type/enhancement An improvement of existing functionality skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 29, 2021
@wxiaoguang wxiaoguang linked an issue Nov 29, 2021 that may be closed by this pull request
Check if cache works correctly during init #17380
Closed
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 29, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 29, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 2, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2021
@wxiaoguang wxiaoguang merged commit 11d519b into go-gitea:main Dec 5, 2021
@wxiaoguang wxiaoguang deleted the test-cache branch December 5, 2021 16:25
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@wxiaoguang
Test cache during init (go-gitea#17852)
a289da5
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@singuliere singuliere singuliere left review comments

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Check if cache works correctly during init
5 participants
@wxiaoguang @lafriks @zeripath @singuliere @GiteaBot