Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ref selection dropdown if you don't have permissions to use it #17837

Merged
merged 4 commits into from Nov 28, 2021
Merged

Disable ref selection dropdown if you don't have permissions to use it #17837

merged 4 commits into from Nov 28, 2021

Conversation

qwerty287
Copy link
Contributor

No description provided.

zeripath
zeripath approved these changes Nov 27, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems simpler and less likely to lead to problems in future

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17837 (4d3e729) into main (fbadc1a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17837      +/-   ##
==========================================
- Coverage   45.55%   45.54%   -0.02%     
==========================================
  Files         808      808              
  Lines       90061    90059       -2     
==========================================
- Hits        41030    41017      -13     
- Misses      42477    42491      +14     
+ Partials     6554     6551       -3
Impacted Files Coverage Δ
routers/web/repo/issue.go 39.02% <ø> (-0.07%) ⬇️
modules/queue/workerpool.go 48.09% <0.00%> (-4.97%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-3.34%) ⬇️
routers/api/v1/repo/pull.go 29.35% <0.00%> (+0.51%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
models/gpg_key_common.go 64.51% <0.00%> (+4.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbadc1a...4d3e729. Read the comment docs.

@lunny lunny merged commit 24a8d54 into go-gitea:main Nov 28, 2021
@qwerty287 qwerty287 deleted the ref-sel branch November 28, 2021 06:50
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@qwerty287 @lafriks @lunny
Disable ref selection dropdown if you don't have permissions to use it (
bad431a 
go-gitea#17837)

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@qwerty287 @codecov-commenter @lafriks @zeripath @lunny @GiteaBot