Fix code formating #17830
Merged
Fix code formating #17830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"make fmt" always want to change this, so better merge it so we do not introduce unrelated changes when running "make fmt" later
wxiaoguang
approved these changes
Nov 26, 2021
GiteaBot
added
the
lgtm/need 1
|
Background: we have our own golang import formatter, #17684, it groups the imports used by code first, and groups the dummy imports second. But our formatter doesn't format imports with comments. So in rare case the output fails lint. |
|
I just made a new commit, now the result of |
wxiaoguang
added
topic/code-linting
skip-changelog
justusbunsi
approved these changes
Nov 27, 2021
GiteaBot
added
lgtm/done
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* fix formatter, format imports first, then go fmt
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"make fmt" always want to change this, so better merge it so
we do not introduce unrelated changes when running "make fmt" later
Second attempt after #17829