Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move more model into models/user #17826

Merged
merged 5 commits into from Nov 28, 2021
Merged

Move more model into models/user #17826

merged 5 commits into from Nov 28, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 26, 2021

as title

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 26, 2021
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 26, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2021 •
edited

Codecov Report

Merging #17826 (72255cd) into main (24a8d54) will not change coverage.
The diff coverage is 43.64%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17826   +/-   ##
=======================================
  Coverage   45.54%   45.54%           
=======================================
  Files         808      808           
  Lines       90059    90059           
=======================================
  Hits        41019    41019           
+ Misses      42491    42484    -7     
- Partials     6549     6556    +7
Impacted Files Coverage Δ
models/error.go 40.00% <ø> (+0.75%) ⬆️
models/migrate.go 0.00% <0.00%> (ø)
models/user.go 37.31% <0.00%> (ø)
routers/api/v1/repo/issue_subscription.go 30.26% <0.00%> (ø)
routers/web/admin/emails.go 0.00% <0.00%> (ø)
routers/web/org/members.go 0.00% <0.00%> (ø)
routers/web/user/auth.go 12.05% <0.00%> (ø)
routers/web/user/setting/account.go 27.47% <0.00%> (ø)
services/auth/login_source.go 0.00% <0.00%> (ø)
services/externalaccount/user.go 0.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a8d54...72255cd. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 28, 2021
@lunny
Copy link
Member Author

lunny commented Nov 28, 2021

make L-G-T-M work

@lunny lunny merged commit 9defddb into go-gitea:main Nov 28, 2021
@lunny lunny deleted the lunny/model_more_user branch November 28, 2021 14:12
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@lunny @6543 @wxiaoguang
Move more model into models/user (go-gitea#17826)
d0af785 
* Move more model into models/user

* Remove unnecessary comment

Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lunny @codecov-commenter @KN4CK3R @wxiaoguang @GiteaBot @6543