Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add archived label for code search results in archived repo's #17817

Merged
merged 3 commits into from Nov 26, 2021

Conversation

jpraet
Copy link
Member

@jpraet jpraet commented Nov 25, 2021

When searching through the code (exlore -> code) you may find results in archived repo's. This PR adds a label to indicate those.

I'm not quite sure if it should actually search through archived repo's though?

Before:

image

After:

image

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #17817 (cc87d91) into main (371ebce) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17817      +/-   ##
==========================================
+ Coverage   45.54%   45.55%   +0.01%     
==========================================
  Files         808      808              
  Lines       90049    90049              
==========================================
+ Hits        41009    41022      +13     
+ Misses      42487    42473      -14     
- Partials     6553     6554       +1     
Impacted Files Coverage Δ
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
models/issue_comment.go 52.40% <0.00%> (-0.57%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
routers/api/v1/repo/pull.go 29.35% <0.00%> (+0.51%) ⬆️
modules/queue/queue_bytefifo.go 59.88% <0.00%> (+0.59%) ⬆️
modules/queue/queue_disk_channel.go 62.72% <0.00%> (+1.77%) ⬆️
modules/queue/workerpool.go 53.43% <0.00%> (+5.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 371ebce...cc87d91. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2021
@silverwind
Copy link
Member

I'm not quite sure if it should actually search through archived repo's though?

I think its helpful to also search achived ones.

@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Nov 26, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 26, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 26, 2021
@lafriks
Copy link
Member

lafriks commented Nov 26, 2021

I'm not quite sure if it should actually search through archived repo's though?

It's useful but could be improved to have option to exclude them from search results. Also would be cool for archived repo results to show after normal repo results (using priority weights)

@lunny
Copy link
Member

lunny commented Nov 26, 2021

I'm not quite sure if it should actually search through archived repo's though?

It's useful but could be improved to have option to exclude them from search results. Also would be cool for archived repo results to show after normal repo results (using priority weights)

These could be another PR. :)

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
…ea#17817)

* Add archived label for code search results in archived repo's

* Remove trailing whitespace

Co-authored-by: Lauris BH <lauris@nix.lv>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants