Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve color when inverting emojis #17797

Merged
merged 1 commit into from Nov 24, 2021
Merged

Conversation

silverwind
Copy link
Member

Fixes: #17795

Windows:

image

Mac:

image

@silverwind silverwind added this to the 1.16.0 milestone Nov 24, 2021
@silverwind silverwind added topic/ui Change the appearance of the Gitea UI type/bug labels Nov 24, 2021
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic!

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 24, 2021
@silverwind silverwind added the backport/done All backports for this PR have been created label Nov 24, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2021
@lunny lunny merged commit 71ed96b into go-gitea:main Nov 24, 2021
@silverwind silverwind deleted the invert-color branch November 24, 2021 12:44
@Gusted
Copy link
Contributor

Gusted commented Nov 24, 2021

Hmm Github somehow approved this while my browser crashes - Anyhow, I wanted to add a comment to my approval

"We should lookout for using invert+hue-rotate as they can create weird sub-pixel artifacts, but that's another issue for another day."

@silverwind
Copy link
Member Author

We should lookout for using invert+hue-rotate as they can create weird sub-pixel artifacts, but that's another issue for another day.

I never noticed anything like that on Mac or Windows at least. Maybe it's a Linux-only issue.

@Gusted
Copy link
Contributor

Gusted commented Nov 24, 2021

I never noticed anything like that on Mac or Windows at least. Maybe it's a Linux-only issue.

I've seen it happening on Windows as well - it's more how browsers are rendering certain things. It's most noticeable on text-like elements which get inverted. It shouldn't be a big problem in this case, but it's not something that should be used everywhere.

@silverwind
Copy link
Member Author

Yeah I recall there having such issues with filter on non-text content, but I guess those are ultimately browser rendering bugs. Doing it on text-only seems fine in any case.

Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji heavy_check_mark: shown as pink instead of green
5 participants