Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of org avatars #17789

Merged
merged 2 commits into from Nov 24, 2021
Merged

Fix visibility of org avatars #17789

merged 2 commits into from Nov 24, 2021

Conversation

qwerty287
Copy link
Contributor

Views org avatars again.

Fixes #17778

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #17789 (51a5ef6) into main (21f4401) will decrease coverage by 0.02%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17789      +/-   ##
==========================================
- Coverage   45.57%   45.54%   -0.03%     
==========================================
  Files         808      808              
  Lines       89982    89987       +5     
==========================================
- Hits        41008    40989      -19     
- Misses      42427    42453      +26     
+ Partials     6547     6545       -2     
Impacted Files Coverage Δ
modules/templates/helper.go 50.34% <63.63%> (+0.25%) ⬆️
modules/queue/workerpool.go 49.23% <0.00%> (-3.06%) ⬇️
modules/notification/mail/mail.go 35.29% <0.00%> (-2.95%) ⬇️
models/unit/unit.go 41.09% <0.00%> (-2.74%) ⬇️
modules/log/event.go 60.64% <0.00%> (-1.86%) ⬇️
modules/queue/queue_bytefifo.go 59.88% <0.00%> (-1.80%) ⬇️
modules/notification/ui/ui.go 60.86% <0.00%> (-1.45%) ⬇️
models/notification.go 64.79% <0.00%> (-0.87%) ⬇️
models/repo_list.go 78.57% <0.00%> (-0.80%) ⬇️
models/issue_comment.go 52.97% <0.00%> (-0.15%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21f4401...51a5ef6. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2021
modules/templates/helper.go Outdated Show resolved Hide resolved
modules/templates/helper.go Outdated Show resolved Hide resolved
modules/templates/helper.go Outdated Show resolved Hide resolved
@lunny
Copy link
Member

lunny commented Nov 24, 2021

I think it's better

switch t := item.(type) {
case *models.Organization:
default:
}

@lunny lunny added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 24, 2021
@lunny
Copy link
Member

lunny commented Nov 24, 2021

@Gusted done.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 24, 2021
@lunny lunny merged commit 754fdd8 into go-gitea:main Nov 24, 2021
@qwerty287 qwerty287 deleted the org-avatar branch November 25, 2021 17:22
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
* Fix visibility of org avatar

* more clear syntax

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Organization avatar is not displayed in headers
6 participants