Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare and check test env during CI #17725

Merged
merged 5 commits into from Nov 19, 2021

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Nov 19, 2021

This PR should resolve the permission problems during CI, if the uid doesn't match, a more clear message is shown.

The new drone step dependencies:

(root)prepare-test-env -> (gitea)build -> (gitea)test

@wxiaoguang wxiaoguang linked an issue Nov 19, 2021 that may be closed by this pull request
@wxiaoguang wxiaoguang added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 19, 2021
@wxiaoguang wxiaoguang added this to the 1.16.0 milestone Nov 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #17725 (c8f467a) into main (a85e75b) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head c8f467a differs from pull request most recent head 10c678d. Consider uploading reports for the commit 10c678d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17725      +/-   ##
==========================================
+ Coverage   45.44%   45.46%   +0.01%     
==========================================
  Files         802      802              
  Lines       89233    89235       +2     
==========================================
+ Hits        40556    40571      +15     
+ Misses      42140    42128      -12     
+ Partials     6537     6536       -1     
Impacted Files Coverage Δ
modules/charset/charset.go 71.71% <0.00%> (-6.07%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
services/gitdiff/gitdiff.go 73.98% <0.00%> (-0.89%) ⬇️
routers/api/v1/repo/pull.go 28.83% <0.00%> (-0.52%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
models/issue_comment.go 52.77% <0.00%> (+0.56%) ⬆️
models/repo_list.go 79.21% <0.00%> (+0.78%) ⬆️
models/notification.go 65.58% <0.00%> (+0.86%) ⬆️
models/project_issue.go 29.90% <0.00%> (+1.33%) ⬆️
modules/notification/ui/ui.go 62.31% <0.00%> (+1.44%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ec656...10c678d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 19, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 19, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 19, 2021
@wxiaoguang wxiaoguang merged commit e4b95de into go-gitea:main Nov 19, 2021
@wxiaoguang wxiaoguang deleted the prepare-test-env branch November 19, 2021 05:58
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
This PR should resolve the permission problems during CI, if the uid doesn't match, a more clear message is shown.

*  CI fails with unknown permission problems go-gitea#17710

The new drone step dependencies:

(root)prepare-test-env -> (gitea)build -> (gitea)test
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails with unknown permission problems
5 participants