Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom regexp external issues #17624

Merged
merged 18 commits into from Jun 10, 2022
Merged

Custom regexp external issues #17624

merged 18 commits into from Jun 10, 2022

Conversation

strk
Copy link
Member

@strk strk commented Nov 12, 2021

This is a rebased version of #4265 with conflicts resolved.

\cc @AlexanderBeyn

Supposedly fixes #3468 but I did not test as I'm currently unable to build Gitea (due to too new Go compiler dependency)

@strk strk mentioned this pull request Nov 12, 2021
Closed
@strk strk force-pushed the custom-regexp-external-issues branch from 1ee37f3 to 0220b5a Compare November 12, 2021 12:21
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2021
@strk strk force-pushed the custom-regexp-external-issues branch 4 times, most recently from 312bff1 to 32baeea Compare November 12, 2021 14:54
@strk strk added the type/enhancement An improvement of existing functionality label Nov 12, 2021
@strk strk force-pushed the custom-regexp-external-issues branch from 32baeea to b5f0048 Compare November 12, 2021 15:41
@AlexanderBeyn @strk
Implement custom regular expression for external issue tracking.
6808b57 
Signed-off-by: Alexander Beyn <malex@fatelectrons.org>
@strk strk force-pushed the custom-regexp-external-issues branch 2 times, most recently from ff7986f to cece1d5 Compare November 12, 2021 17:38
@strk strk force-pushed the custom-regexp-external-issues branch from cece1d5 to 7ac7a0e Compare November 12, 2021 17:58
@strk
Copy link
Member Author

strk commented Nov 12, 2021

I'm letting this go for today and next few days, dunno if I'll have time to catch up again so please if @techknowlogick or @zeripath want to continue from here I'm happy :)

@6543 6543 added this to the 1.17.0 milestone May 7, 2022
@6543
Copy link
Member

6543 commented May 7, 2022

@strk can you enable maintainers to edit this pull - or resolve conflicts :)

@strk
Copy link
Member Author

strk commented May 9, 2022

"Allow edits by maintainers" is checked already

@6543
Copy link
Member

6543 commented May 9, 2022

hmm strange - I can't push to the pull head

@strk
Copy link
Member Author

strk commented May 9, 2022

I'm afraid github concept of "maintainer" is different from Gitea one. For GitHub, "maintainers" are those with "write access to repository". I know I'm a Gitea mintainer while NOT having write access to it. Feel free to take over this PR by creating a new one, or send a pull request for my fork

@6543
Copy link
Member

6543 commented May 9, 2022

well I do have write-access ... tldr: I'll create a pull

@luiscla27
Copy link

How is this going? :)

@6543
Copy link
Member

6543 commented May 29, 2022

thanks for the ping ;)

@6543
Copy link
Member

6543 commented May 29, 2022

@strk strk#2

@wxiaoguang wxiaoguang force-pushed the custom-regexp-external-issues branch from 6d21a64 to 0b88fbc Compare June 9, 2022 16:13
@wxiaoguang
Copy link
Contributor

OK, CI passes, and the frontend has been refactored together.

Maybe it's possible to get it in 1.17

wxiaoguang
wxiaoguang approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test, it works.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 9, 2022
@wxiaoguang wxiaoguang force-pushed the custom-regexp-external-issues branch from 5572f99 to 94c4953 Compare June 9, 2022 17:30
@silverwind
Copy link
Member

silverwind commented Jun 9, 2022 •
edited

Maybe you could do a do-release-upgrade, instead of using a EOL distro without security patches.

https://ubuntu.com/about/release-cycle , https://wiki.ubuntu.com/Releases
Version Code name Release End of Life
Ubuntu 21.04 Hirsute Hippo April 22, 2021 January 20, 2022

Or just use the official nodesource repo which is much better than the EOL versions that are in base Debian/Ubuntu repos.

@6543 6543 requested a review from silverwind June 10, 2022 02:01
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2022
@lunny
Copy link
Member

lunny commented Jun 10, 2022

make L-G-T-M work.

@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Jun 10, 2022
@lunny lunny merged commit 52c2e82 into go-gitea:main Jun 10, 2022
@strk
Copy link
Member Author

strk commented Jun 10, 2022 via email

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 11, 2022
@zjjhot
Merge remote-tracking branch 'giteaoffical/main'
4ae06ff 
* giteaoffical/main:
  Fix data-race problems in git module (quick patch) (go-gitea#19934)
  [skip ci] Updated translations via Crowdin
  Fix copy/paste of empty lines (go-gitea#19798)
  Normalize line endings in fomantic build files (go-gitea#19932)
  Make user profile image show full image on mobile (go-gitea#19840)
  Custom regexp external issues (go-gitea#17624)
  Use Golang 1.18 for Gitea 1.17 release (go-gitea#19918)
  Refactor git module, make Gitea use internal git config (go-gitea#19732)
  [skip ci] Updated translations via Crowdin
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@strk @AlexanderBeyn
@techknowlogick @lafriks @6543 @wxiaoguang @AbdulrhmnGhanem
Custom regexp external issues (go-gitea#17624)
7778e5b 
* Implement custom regular expression for external issue tracking.

Signed-off-by: Alexander Beyn <malex@fatelectrons.org>

* Fix syntax/style

* Update repo.go

* Set metas['regexp']

* gofmt

* fix some tests

* fix more tests

* refactor frontend

* use LRU cache for regexp

* Update modules/markup/html_internal_test.go

Co-authored-by: Alexander Beyn <malex@fatelectrons.org>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: 6543 <6543@obermui.de>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@andrewimeson andrewimeson mentioned this pull request Oct 4, 2022
Closed
@wxiaoguang wxiaoguang mentioned this pull request Mar 1, 2023
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@delvh delvh removed the type/changelog Adds the changelog for a new Gitea version label Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@6543 6543 6543 approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Allow custom regex patterns for linking external issues