Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double imports #17569

Merged
merged 4 commits into from Nov 8, 2021
Merged

Avoid double imports #17569

merged 4 commits into from Nov 8, 2021

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Nov 6, 2021

A little refactor to enables the [rule.duplicated-imports] which seems to be able to pick-up these cases. And fix existing cases whereby a file imported a package twice.

@codecov-commenter
Copy link

Codecov Report

Merging #17569 (aa72c60) into main (bd613c7) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17569      +/-   ##
==========================================
- Coverage   45.49%   45.48%   -0.01%     
==========================================
  Files         793      793              
  Lines       88811    88811              
==========================================
- Hits        40401    40397       -4     
  Misses      41897    41897              
- Partials     6513     6517       +4
Impacted Files Coverage Δ
models/issue.go 58.17% <0.00%> (ø)
routers/api/v1/repo/transfer.go 60.46% <0.00%> (ø)
modules/migrations/gitea_uploader.go 6.62% <50.00%> (ø)
modules/convert/convert.go 79.66% <100.00%> (ø)
modules/git/repo_base_nogogit.go 82.85% <0.00%> (-2.86%) ⬇️
modules/git/utils.go 68.05% <0.00%> (-2.78%) ⬇️
models/issue_comment.go 51.31% <0.00%> (-0.59%) ⬇️
modules/queue/workerpool.go 48.85% <0.00%> (+0.76%) ⬆️
modules/queue/queue_channel.go 96.66% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd613c7...aa72c60. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 6, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 7, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 7, 2021
@lafriks lafriks merged commit ebaf4c4 into go-gitea:main Nov 8, 2021
@Gusted Gusted deleted the double-imports branch November 8, 2021 19:45
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
@Gusted @lunny
@techknowlogick @wxiaoguang
Avoid double imports (go-gitea#17569)
4aceb72 
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Gusted @codecov-commenter @lunny @lafriks @zeripath @GiteaBot @techknowlogick @wxiaoguang