Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty envelope sender in mail notifications #17477

Closed
pboguslawski opened this issue Oct 28, 2021 · 0 comments · Fixed by #17479
Closed

Empty envelope sender in mail notifications #17477

pboguslawski opened this issue Oct 28, 2021 · 0 comments · Fixed by #17479

Comments

@pboguslawski
Copy link
Contributor

Feature Description

Mail notifications sent by Gitea (like info about being added to repo as collaborator, checked in v1.13) have nonempty envelope sender which may generate unnecessary bounces in case of delivery problems. Now address configured in

[mailer]
FROM = Name <address@example.com>

generates messages with

Return-Path: <address@example.com>
From: Name <address@example.com>

Consider setting empty envelope sender which is allowed i.e. for bounces to avoid loops

https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.2

With empty envelope sender messages should contain

Return-Path: <>
From: Name <address@example.com>

Not sure but places to be modified are:

https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L245
https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L213

Screenshots

No response
zeripath added a commit to zeripath/gitea that referenced this issue Oct 28, 2021
@zeripath
Add settings to allow different SMTP envelope from address
641aaa1 
Sometimes it may be advisable to hide or alias the from address on an SMTP mail
envelope. This PR adds two new options to the mailer to allow setting of an overriding
from address.

Fix go-gitea#17477

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Oct 28, 2021
Merged
wxiaoguang pushed a commit that referenced this issue Nov 19, 2021
@zeripath
Add settings to allow different SMTP envelope from address (#17479)
38347aa 
* Add settings to allow different SMTP envelope from address

Sometimes it may be advisable to hide or alias the from address on an SMTP mail
envelope. This PR adds two new options to the mailer to allow setting of an overriding
from address.

Fix #17477

Signed-off-by: Andrew Thornton <art27@cantab.net>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@zeripath
Add settings to allow different SMTP envelope from address (go-gitea#…
4262a1c 
…17479)

* Add settings to allow different SMTP envelope from address

Sometimes it may be advisable to hide or alias the from address on an SMTP mail
envelope. This PR adds two new options to the mailer to allow setting of an overriding
from address.

Fix go-gitea#17477

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add settings to allow different SMTP envelope from address zeripath/gitea
1 participant
@pboguslawski