Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move from io/ioutil to io and os package #17109

Merged
merged 2 commits into from Sep 22, 2021
Merged

refactor: move from io/ioutil to io and os package #17109

merged 2 commits into from Sep 22, 2021

Conversation

Juneezee
Copy link
Contributor

The io/ioutil package has been deprecated in Go 1.16 (See https://golang.org/doc/go1.16#ioutil). This PR replaces the existing io/ioutil functions with their new definitions in io and os packages.

This PR is partly related to #16764.

@Juneezee
refactor: move from io/ioutil to io and os package
90e8534 
The io/ioutil package has been deprecated as of Go 1.16, see
https://golang.org/doc/go1.16#ioutil. This commit replaces the existing
io/ioutil functions with their new definitions in io and os packages.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
@axifive axifive added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Sep 21, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 21, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@aa631d8). Click here to learn what that means.
The diff coverage is 41.23%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #17109   +/-   ##
=======================================
  Coverage        ?   45.31%           
=======================================
  Files           ?      773           
  Lines           ?    86873           
  Branches        ?        0           
=======================================
  Hits            ?    39364           
  Misses          ?    41147           
  Partials        ?     6362
Impacted Files Coverage Δ
cmd/dump.go 0.91% <0.00%> (ø)
models/repo.go 54.44% <0.00%> (ø)
modules/context/repo.go 52.99% <0.00%> (ø)
modules/doctor/paths.go 14.49% <0.00%> (ø)
modules/git/repo_commit.go 42.35% <0.00%> (ø)
modules/git/repo_tree_nogogit.go 49.01% <0.00%> (ø)
modules/graceful/server.go 52.30% <0.00%> (ø)
modules/indexer/code/elastic_search.go 1.65% <0.00%> (ø)
modules/markup/external/external.go 1.61% <0.00%> (ø)
modules/migrations/restore.go 0.00% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa631d8...5ff0101. Read the comment docs.

@lunny lunny merged commit f2e7d54 into go-gitea:main Sep 22, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@axifive axifive axifive approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Juneezee @codecov-commenter @lunny @axifive @GiteaBot @6543 @techknowlogick