Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge endpoints for pull diff/patch #17104

Merged
merged 3 commits into from Sep 21, 2021
Merged

Merge endpoints for pull diff/patch #17104

merged 3 commits into from Sep 21, 2021

Conversation

qwerty287
Copy link
Contributor

As discussed in #17095 (comment), this merges the two API endpoints for the PR diff/patch in to one, like for the commits.

@6543 6543 added modifies/api This PR adds API routes or modifies them pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! type/docs This PR mainly updates/creates documentation type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Sep 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #17104 (6b1a88b) into main (b231d0d) will increase coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17104      +/-   ##
==========================================
+ Coverage   45.30%   45.32%   +0.01%     
==========================================
  Files         773      773              
  Lines       86873    86873              
==========================================
+ Hits        39356    39371      +15     
+ Misses      41152    41140      -12     
+ Partials     6365     6362       -3     
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 29.03% <0.00%> (-0.05%) ⬇️
routers/api/v1/api.go 78.19% <100.00%> (-0.03%) ⬇️
modules/queue/queue_channel.go 91.66% <0.00%> (-3.34%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
services/pull/pull.go 41.78% <0.00%> (-0.41%) ⬇️
models/issue_comment.go 51.90% <0.00%> (+0.58%) ⬆️
modules/queue/queue_bytefifo.go 63.47% <0.00%> (+0.59%) ⬆️
models/repo_list.go 78.43% <0.00%> (+0.78%) ⬆️
modules/queue/workerpool.go 51.14% <0.00%> (+1.14%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b231d0d...6b1a88b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 20, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 20, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 21, 2021
@6543
Copy link
Member

6543 commented Sep 21, 2021

🚀

@6543 6543 merged commit 0fa153f into go-gitea:main Sep 21, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 21, 2021
@qwerty287 qwerty287 deleted the pull-merge-api branch September 23, 2021 17:07
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@noerw noerw removed the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Jan 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/docs This PR mainly updates/creates documentation type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants