Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete branches include / charactors after PR failed #1692

Closed
wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented May 8, 2017

should fix #1397, but now the tests cannot be PASS because it seems macaron route's bug.

@lunny lunny added type/bug status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels May 8, 2017
@lunny lunny added this to the 1.2.0 milestone May 8, 2017
@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 24, 2017
@lunny lunny removed this from the 1.2.0 milestone May 25, 2017
@lunny
Copy link
Member Author

lunny commented May 25, 2017

It seems that macaron don't support the route /a/*/delete to match /a/b/c/delete. @unknwon

@unknwon
Copy link
Contributor

unknwon commented May 25, 2017

You're right, unfortunately, it does not...

@lunny
Copy link
Member Author

lunny commented May 25, 2017

I will send another PR to fix this.

@lunny lunny closed this May 25, 2017
@lunny lunny deleted the lunny/fix_delete_branch branch June 20, 2017 05:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot delete branch with slash in name after PR
3 participants