Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent "Race" detected in TestAdmin*User #16830

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

zeripath
Copy link
Contributor

These tests are missing the defer prefix.

Related #1441

Signed-off-by: Andrew Thornton art27@cantab.net

These tests are missing the defer prefix.

Related go-gitea#1441

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.16.0 milestone Aug 26, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 27, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 27, 2021
@6543
Copy link
Member

6543 commented Aug 27, 2021

🪨

@6543 6543 merged commit cd8db3a into go-gitea:main Aug 27, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 27, 2021
@zeripath zeripath deleted the prevent-log-race-detection branch August 27, 2021 13:15
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants