Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a common quote to instead of check database type #16817

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 25, 2021

`` will be converted to different database quote by xorm. So check database type is unnecessary.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2021

Codecov Report

Merging #16817 (00721a4) into main (697213b) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16817      +/-   ##
==========================================
- Coverage   45.47%   45.46%   -0.01%     
==========================================
  Files         762      762              
  Lines       85975    85969       -6     
==========================================
- Hits        39095    39090       -5     
- Misses      40563    40564       +1     
+ Partials     6317     6315       -2     
Impacted Files Coverage Δ
models/user.go 54.55% <100.00%> (+0.14%) ⬆️
modules/charset/charset.go 71.71% <0.00%> (-2.03%) ⬇️
modules/queue/workerpool.go 53.81% <0.00%> (-1.91%) ⬇️
modules/log/event.go 60.64% <0.00%> (-1.86%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
services/gitdiff/gitdiff.go 73.25% <0.00%> (-0.98%) ⬇️
models/repo_list.go 77.64% <0.00%> (-0.79%) ⬇️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
models/error.go 39.53% <0.00%> (+0.46%) ⬆️
models/notification.go 66.00% <0.00%> (+0.87%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 697213b...00721a4. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 25, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 25, 2021
@zeripath zeripath merged commit b88dbe1 into go-gitea:main Aug 25, 2021
@lunny lunny deleted the lunny/refactor_quote branch August 25, 2021 13:36
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants