Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not all branches shown in branch pagination #16801

Closed
2 of 6 tasks
eNBeWe opened this issue Aug 24, 2021 · 1 comment · Fixed by #16805
Closed
2 of 6 tasks

Not all branches shown in branch pagination #16801

eNBeWe opened this issue Aug 24, 2021 · 1 comment · Fixed by #16805
Labels
type/bug
Milestone
1.15.1

Comments

@eNBeWe
Copy link

eNBeWe commented Aug 24, 2021 •
edited

Description

  • When I create 20 branches (in addition to the default branch), the branch page of the repository doesn't show the pagination bar
    and the last branch is not shown.
  • I can manually navigate to the second page by appending ?page=2 to the url and the branch is shown.
  • Similar, if I add 20 more branches, the pagination bar is missing the last (third) page

Screenshots

branch-view-01

branch-view-02

branch-view-03
@eNBeWe
Copy link
Author

eNBeWe commented Aug 24, 2021

If I push another branch, the next page is shown in the pagination bar. That means on the last page there need to be two branches to be shown.

@lunny lunny mentioned this issue Aug 24, 2021
Merged
@lunny lunny added the type/bug label Aug 24, 2021
@lunny lunny added this to the 1.15.1 milestone Aug 24, 2021
zeripath pushed a commit that referenced this issue Aug 24, 2021
@lunny
Fix branch pagination error (#16805)
4e761fa 
Fix #16801

Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
lunny added a commit to lunny/gitea that referenced this issue Aug 25, 2021
@lunny
Fix branch pagination error (go-gitea#16805)
d7511c5 
Fix go-gitea#16801

Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
@lunny lunny mentioned this issue Aug 25, 2021
Merged
zeripath pushed a commit that referenced this issue Aug 25, 2021
@lunny
Fix branch pagination error (#16805) (#16816)
ab7e36e 
Backport #16805

Fix #16801

Even if default branch is removed from the current page, but the total branches number should be still kept. So that the pagination calculation will be correct.
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.15.1
Development

Successfully merging a pull request may close this issue.

Fix branch pagination error lunny/gitea
2 participants
@lunny @eNBeWe