Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EdDSA JWT signing algorithm #16786

Merged
merged 4 commits into from Aug 25, 2021
Merged

Add EdDSA JWT signing algorithm #16786

merged 4 commits into from Aug 25, 2021

Conversation

amenzhinsky
Copy link
Contributor

Hi there.

Currently EdDSA signing algorithm is missing and this PR adds the support.

Here are few links to RFCs:
https://www.iana.org/assignments/jose/jose.xhtml#web-signature-encryption-algorithms
https://datatracker.ietf.org/doc/html/rfc8037

@codecov-commenter

This comment has been minimized.

Sign in to view
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 23, 2021
@lunny lunny added the type/enhancement An improvement of existing functionality label Aug 24, 2021
KN4CK3R
KN4CK3R approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@KN4CK3R KN4CK3R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered why I should have left that one out... it was added a month ago in the jwt lib 😏

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 24, 2021
@KN4CK3R
Copy link
Member

KN4CK3R commented Aug 24, 2021

Could you please fix the spelling error in CreateJWTSingingKey while you are there? We are not singing.

@amenzhinsky
Copy link
Contributor Author

amenzhinsky commented Aug 25, 2021 •
edited

@KN4CK3R tbh I'm not getting where is the typo.

@KN4CK3R
Copy link
Member

KN4CK3R commented Aug 25, 2021 

CreateJWTSingingKey
CreateJWTSigningKey
           ^^

@amenzhinsky
Copy link
Contributor Author

@KN4CK3R done, didn't see that whatsoever, the British scientists claim that it's enough to see the first and the last letter in the word to read it 😄

@lunny lunny added this to the 1.16.0 milestone Aug 25, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 25, 2021
@techknowlogick techknowlogick merged commit 28ac4a7 into go-gitea:main Aug 25, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amenzhinsky @codecov-commenter @KN4CK3R @lunny @techknowlogick @GiteaBot