Refactor the fork service slightly to take ForkRepoOptions

[kevans91]

This reduces the number of places we need to change if we want to add other
options during fork time.

Signed-off-by: Kyle Evans kevans@FreeBSD.org

[kevans91]

I guess I should have mentioned: I have some local WIP that adds an option to disallow forking of a fork, the idea being that one could setup (in a highly controlled environment) something like: org1/repo forked to user1/repo with forking disabled on the latter, then forking is disabled on the former to prevent further forks.

[jolheiser]

I guess I should have mentioned: I have some local WIP that adds an option to disallow forking of a fork, the idea being that one could setup (in a highly controlled environment) something like: org1/repo forked to user1/repo with forking disabled on the latter, then forking is disabled on the former to prevent further forks.

Just to clarify, there is still nothing inherently stopping someone from cloning and simply pushing to another remote (even on the same instance).

[kevans91]

I guess I should have mentioned: I have some local WIP that adds an option to disallow forking of a fork, the idea being that one could setup (in a highly controlled environment) something like: org1/repo forked to user1/repo with forking disabled on the latter, then forking is disabled on the former to prevent further forks.

Just to clarify, there is still nothing inherently stopping someone from cloning and simply pushing to another remote.

Right, the point isn't to stop someone from cloning the repo, it's to stop them from taking up more space or providing an authoritative looking repository on "this" server. The latter forbids new repos in general, but forks are a loophole.

[codecov-commenter]

Codecov Report

Merging #16744 (5e47dc5) into main (0393789) will decrease coverage by 0.03%.
The diff coverage is 86.20%.

@@            Coverage Diff             @@
##             main   #16744      +/-   ##
==========================================
- Coverage   45.40%   45.36%   -0.04%     
==========================================
  Files         760      760              
  Lines       85483    85491       +8     
==========================================
- Hits        38814    38784      -30     
- Misses      40389    40423      +34     
- Partials     6280     6284       +4     

Impacted Files	Coverage Δ
models/repo.go	54.77% <ø> (ø)
modules/repository/fork.go	48.38% <75.00%> (ø)
routers/api/v1/repo/fork.go	26.66% <100.00%> (+7.15%)	⬆️
routers/web/repo/pull.go	30.32% <100.00%> (+0.30%)	⬆️
services/repository/repository.go	52.27% <100.00%> (ø)
modules/util/timer.go	42.85% <0.00%> (-42.86%)	⬇️
models/repo_mirror.go	58.69% <0.00%> (-10.87%)	⬇️
services/mirror/mirror.go	9.61% <0.00%> (-7.70%)	⬇️
modules/cron/tasks_basic.go	85.43% <0.00%> (-2.92%)	⬇️
modules/queue/manager.go	65.34% <0.00%> (-2.85%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0393789...5e47dc5. Read the comment docs.

[zeripath]

Needs go fmt but otherwise looks good

[kevans91]

Bah, sorry, fixed.