Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The gogit implementation of git notes differs from the nogogit implementation #16657

Closed
2 of 6 tasks
nitul1991 opened this issue Aug 9, 2021 · 0 comments · Fixed by #16658
Closed
2 of 6 tasks

The gogit implementation of git notes differs from the nogogit implementation #16657

nitul1991 opened this issue Aug 9, 2021 · 0 comments · Fixed by #16658

Comments

@nitul1991
Copy link
Contributor

  • Gitea version (or commit ref): 1dc41c4
  • Git version: 2.32.0
  • Operating system: macOS Catalina version 10.15.6
  • I built gitea from source and ran the tests via the command-line.
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

Whilst working on the issue #15373, I discovered that the implementation of the gogit version of git notes differs from the no-gogit version when a non existent commit ID is passed to the function GitNote.
I brought this up on Discord and @zeripath suggested that I provide a fix for this issue in a separate PR so that it can be backported to version 1.15.
@nitul1991 nitul1991 mentioned this issue Aug 9, 2021
Merged
@zeripath zeripath linked a pull request Aug 9, 2021 that will close this issue
Change the behaviour of the go-git version of the GetNote function in reponse to a non-existent commit ID #16658
Merged
nitul1991 added a commit to nitul1991/gitea that referenced this issue Aug 9, 2021
@nitul1991
Change the implementation of the go-git version of GetNote to mirror …
caed084 
…the non go-git version when passed a non-existent commit (go-gitea#16658)

Fixes go-gitea#16657
zeripath pushed a commit that referenced this issue Aug 9, 2021
@nitul1991
Change the implementation of the go-git version of GetNote to mirror …
e483ec8 
…the non go-git version when passed a non-existent commit (#16658) (#16659)

Backport #16658

Fixes #16657
Codeberg-org pushed a commit to Codeberg-org/gitea that referenced this issue Aug 24, 2021
@nitul1991
Change the implementation of the go-git version of GetNote to mirror …
8eab16d 
…the non go-git version when passed a non-existent commit (go-gitea#16658) (go-gitea#16659)

Backport go-gitea#16658

Fixes go-gitea#16657
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@nitul1991