Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization custom avatar only gets updated on browser cache reset #165

Closed
gencer opened this issue Nov 13, 2016 · 10 comments · Fixed by #721
Closed

Organization custom avatar only gets updated on browser cache reset #165

gencer opened this issue Nov 13, 2016 · 10 comments · Fixed by #721
Labels
Milestone

Comments

@gencer
Copy link

gencer commented Nov 13, 2016

When a new organization avatar get uploaded you get a message says:

Organization avatar setting has been updated successfully.

File is uploaded to data/avatars/{orgId} but it does not show up on frontend.

Until you Ctrl+ F5 or reset browser cache. It should reflect change immediately.

@gencer gencer changed the title Organization custom avatar upload not working Organization custom avatar only gets updated on browser cache reset Nov 13, 2016
@thibaultmeyer
Copy link
Contributor

thibaultmeyer commented Nov 13, 2016

Maybe you have cache. Try to call directly /avatars/{id} (use force refresh: CTRL-SHIFT-R on Chrome) and refresh organisation page.

@gencer
Copy link
Author

gencer commented Nov 13, 2016

Indeed I had a cache.

@tboerger tboerger added this to the 1.1.0 milestone Nov 24, 2016
@tboerger
Copy link
Member

So let's refine the cache headers for the avatars.

@Bwko
Copy link
Member

Bwko commented Jan 5, 2017

It looks like this issue got fixed

@lunny
Copy link
Member

lunny commented Jan 6, 2017

Really? But which PR fixed this?

@Bwko
Copy link
Member

Bwko commented Jan 6, 2017

@lunny Nvm somehow disable cache was checked >_<

@lunny
Copy link
Member

lunny commented Jan 6, 2017

Then, just close this one? @gencer could you confirm this is resolved?

@Bwko
Copy link
Member

Bwko commented Jan 7, 2017

@lunny No, my browser did not cache any images so it looked like it was fixed.
I've create a branch to add ETag headers to macaron and fixing this issue.
Maybe we should fork macaron to add things like this?

@lunny
Copy link
Member

lunny commented Jan 8, 2017

fork macaron and send PR to the original? Maybe we will change macaron to other framework some time.

@Bwko
Copy link
Member

Bwko commented Jan 8, 2017

@lunny Done, now I hope that Unknwon merges this PR in the next couple of days.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants