Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git ref Prefix should be const's in modules/git/ref.go #16478

Closed
6543 opened this issue Jul 18, 2021 · 0 comments · Fixed by #17784
Closed

git ref Prefix should be const's in modules/git/ref.go #16478

6543 opened this issue Jul 18, 2021 · 0 comments · Fixed by #17784
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.

Comments

@6543
Copy link
Member

6543 commented Jul 18, 2021 •
edited

... it need a refactor ...
-> I propose to move things into modules/git/ref.go and replace strings in code with that const ... witch is worth it's own pull

Originally posted by @6543 in #14295 (comment)

  • refs/tags
  • refs/heads
  • refs/remotes
    ...
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 18, 2021
@mscherer mscherer mentioned this issue Nov 23, 2021
Merged
mscherer added a commit to mscherer/gitea that referenced this issue Dec 1, 2021
@mscherer @Gusted
Refactor various strings
fc2256f 
Fixes go-gitea#16478

Co-authored-by: Gusted <williamzijl7@hotmail.com>
lunny added a commit that referenced this issue Dec 2, 2021
@mscherer @Gusted @lunny
Refactor various strings (#17784)
34b5436 
Fixes #16478

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@mscherer @Gusted @lunny
Refactor various strings (go-gitea#17784)
900459f 
Fixes go-gitea#16478

Co-authored-by: Gusted <williamzijl7@hotmail.com>

Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor "refs/*" string usage by using constants mscherer/gitea
1 participant
@6543