Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup code getIssueFullPattern in modules/markup #16419

Merged
merged 5 commits into from Jul 15, 2021

Conversation

Dexus
Copy link
Contributor

@Dexus Dexus commented Jul 13, 2021

fix #16415

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 13, 2021
@6543 6543 requested a review from zeripath July 13, 2021 15:39
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jul 13, 2021
@6543 6543 added this to the 1.15.0 milestone Jul 13, 2021
@zeripath zeripath modified the milestones: 1.15.0, 1.16.0 Jul 13, 2021
@zeripath
Copy link
Contributor

I think this doesn't need to go in to 1.15 - the "race" is somewhat theoretical as we can assert that Init() gets called and completes before anything else would call the get* fn. There's likely to be another Once we can use to for setting these regexps too but I'll have to have a deeper look,

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16419 (8ab468b) into main (0393a57) will increase coverage by 1.18%.
The diff coverage is 49.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16419      +/-   ##
==========================================
+ Coverage   44.24%   45.42%   +1.18%     
==========================================
  Files         695      717      +22     
  Lines       82341    84108    +1767     
==========================================
+ Hits        36429    38206    +1777     
+ Misses      40014    39749     -265     
- Partials     5898     6153     +255     
Impacted Files Coverage Δ
cmd/convert.go 0.00% <0.00%> (ø)
cmd/dump.go 0.91% <0.00%> (ø)
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/generate.go 0.00% <0.00%> (ø)
cmd/hook.go 0.00% <0.00%> (ø)
cmd/migrate.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 0.00% <0.00%> (ø)
cmd/serv.go 2.36% <0.00%> (-0.22%) ⬇️
cmd/web.go 0.00% <0.00%> (ø)
cmd/web_letsencrypt.go 0.00% <0.00%> (ø)
... and 307 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update febee86...8ab468b. Read the comment docs.

@6543 6543 merged commit 8d962da into go-gitea:main Jul 15, 2021
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jul 15, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bugfix: concurrent save getIssueFullPattern
6 participants