Use gitea logging module for git module

[6543]

remove log() func from gogs times and switch to proper logging

[lunny]

Have you tested if ssh feature is OK? Why the log left because when run gitea serv/hooks commands, you cannot output errors directly to console.

[codecov-commenter]

Codecov Report

Merging #16243 (b3fe07b) into main (0393a57) will increase coverage by 1.24%.
The diff coverage is 48.95%.

@@            Coverage Diff             @@
##             main   #16243      +/-   ##
==========================================
+ Coverage   44.24%   45.49%   +1.24%     
==========================================
  Files         695      705      +10     
  Lines       82341    83150     +809     
==========================================
+ Hits        36429    37825    +1396     
+ Misses      40014    39257     -757     
- Partials     5898     6068     +170     

Impacted Files	Coverage Δ
cmd/generate.go	0.00% <0.00%> (ø)
cmd/hook.go	0.00% <0.00%> (ø)
models/action.go	47.12% <ø> (ø)
models/oauth2.go	28.00% <0.00%> (-1.17%)	⬇️
models/repo_archiver.go	0.00% <0.00%> (ø)
models/user.go	52.32% <ø> (-1.07%)	⬇️
modules/context/repo.go	52.99% <0.00%> (-0.30%)	⬇️
modules/generate/generate.go	0.00% <0.00%> (-16.00%)	⬇️
modules/git/blob_nogogit.go	61.19% <0.00%> (ø)
modules/git/diff.go	75.31% <0.00%> (ø)
... and 201 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 837e8b3...b3fe07b. Read the comment docs.

[6543]

build in ssh works & we can remove this logging but i think it's ok - feel free to add delete suggestions :)

[zeripath]

Have you tested if ssh feature is OK? Why the log left because when run gitea serv/hooks commands, you cannot output errors directly to console.

Ah so my changes here:

gitea/cmd/serv.go

Lines 52 to 63 in 837e8b3

	func setup(logPath string, debug bool) {
	_ = log.DelLogger("console")
	if debug {
	_ = log.NewLogger(1000, "console", "console", `{"level":"trace","stacktracelevel":"NONE","stderr":true}`)
	} else {
	_ = log.NewLogger(1000, "console", "console", `{"level":"fatal","stacktracelevel":"NONE","stderr":true}`)
	}
	setting.NewContext()
	if debug {
	setting.RunMode = "dev"
	}
	}

Mean that it will work fine.

[zeripath]

Ok we need to do the setlogger thing in maintest in git

[zeripath]

make lgtm work

[jpraet]

I get some debug and trace logging at startup even when only info logging is enabled, I think because the LogService is not yet initialized at that point.

gitea/modules/git/command.go

Line 202 in 622f1e7

log.Trace("Stdout:\n %s", stdout.Bytes()[:1024])

This generates these \003d in the logs:

2021/06/26 09:58:47 ...dules/git/command.go:118:RunInDirTimeoutEnvFullPipelineFunc() [D] C:\Program Files\Git\mingw64\bin\git.exe version
2021/06/26 09:58:48 ...dules/git/command.go:202:RunInDirTimeoutEnv() [T] Stdout:
         git version 2.18.0.windows.1
        \003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d\003d etc...

[zeripath]

Don't comment on merged or closed issues and pulls open a new one and reference instead.

I'll take a look though

[zeripath]

OK I think we still need the Trace otherwise there's a serious deprecation in logging - however, we're actually printing out mostly from the buffer here instead of the actual output.

Now we have to think about how we're going to sort out the rest of the logging that happens - it's kinda bad to get this stuff emitted. I guess we should just move the logging initiation higher in the settings hierarchy.

(Realistically a proper dependency management system would have asserted that anyway.)