Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reqOrgMembership calls need to be preceded by reqToken #16198

Merged
merged 5 commits into from
Jun 21, 2021
Merged

reqOrgMembership calls need to be preceded by reqToken #16198

merged 5 commits into from
Jun 21, 2021

Conversation

zeripath
Copy link
Contributor

Fix #16192

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
reqOrgMembership calls need to be preceded by reqToken
2d9c8a3 
Fix go-gitea#16192

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug modifies/api This PR adds API routes or modifies them backport/v1.14 labels Jun 18, 2021
@zeripath zeripath added this to the 1.15.0 milestone Jun 18, 2021
6543
6543 reviewed Jun 18, 2021
View reviewed changes
routers/api/v1/api.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 18, 2021
noerw
noerw reviewed Jun 19, 2021
View reviewed changes
Copy link
Member

@noerw noerw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test fail is same as in #15909 (comment)

@zeripath
Add csrf to TestAPITeamSearch
df2a41b 
Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2021 •
edited

Codecov Report

Merging #16198 (db923cb) into main (4fcae3d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #16198   +/-   ##
=======================================
  Coverage   45.56%   45.56%           
=======================================
  Files         702      702           
  Lines       82929    82929           
=======================================
+ Hits        37784    37787    +3     
+ Misses      39096    39095    -1     
+ Partials     6049     6047    -2
Impacted Files Coverage Δ
routers/api/v1/api.go 78.29% <100.00%> (ø)
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
services/pull/pull.go 41.97% <0.00%> (ø)
models/repo_list.go 77.82% <0.00%> (+0.77%) ⬆️
modules/context/api.go 75.25% <0.00%> (+1.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcae3d...db923cb. Read the comment docs.

@zeripath
Copy link
Contributor Author

Thanks @noerw that appears to have sorted it.

@zeripath @6543
Apply suggestions from code review
1918cc7 
Co-authored-by: 6543 <6543@obermui.de>
@noerw noerw mentioned this pull request Jun 21, 2021
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2021
@zeripath zeripath merged commit 681e81b into go-gitea:main Jun 21, 2021
@zeripath zeripath deleted the fix-16192-reqOrgMembership-requires-reqToken branch June 21, 2021 13:01
zeripath added a commit to zeripath/gitea that referenced this pull request Jun 21, 2021
@zeripath @6543
reqOrgMembership calls need to be preceded by reqToken (go-gitea#16198)
06e21d2 
Backport go-gitea#16198

ReqOrgMembership calls need to be preceded by reqToken

Fix go-gitea#16192

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
@zeripath zeripath mentioned this pull request Jun 21, 2021
Merged
zeripath added a commit that referenced this pull request Jun 21, 2021
@zeripath @6543
reqOrgMembership calls need to be preceded by reqToken (#16198) (#16219)
d407857 
Backport #16198

ReqOrgMembership calls need to be preceded by reqToken

Fix #16192

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
@zeripath zeripath added the backport/done All backports for this PR have been created label Jun 21, 2021
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @6543 @AbdulrhmnGhanem
reqOrgMembership calls need to be preceded by reqToken (go-gitea#16198)
b1a10e1 
ReqOrgMembership calls need to be preceded by reqToken

Fix go-gitea#16192

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noerw noerw noerw approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Internal Server Error on endpoint ​/orgs​/{org}​/teams - List an organization's teams
5 participants
@zeripath @codecov-commenter @noerw @6543 @GiteaBot