Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog v1.14.3 #16131

Merged
merged 9 commits into from Jun 18, 2021
Merged

Changelog v1.14.3 #16131

merged 9 commits into from Jun 18, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 10, 2021

as title

@6543 6543 added type/docs This PR mainly updates/creates documentation skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jun 10, 2021
@6543 6543 added this to the 1.14.3 milestone Jun 10, 2021
@6543
Copy link
Member Author

6543 commented Jun 10, 2021

just blocked by #16068 and it's backport

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2021
6543
6543 commented Jun 10, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
6543
6543 commented Jun 10, 2021
View reviewed changes
Copy link
Member Author

@6543 6543 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready from my side 🚀

@6543 6543 requested a review from lafriks June 10, 2021 21:32
@tomaswarynyca
Copy link
Contributor

tomaswarynyca commented Jun 10, 2021 •
edited

@6543 Could #16130 be fixed before releasing the new version?

techknowlogick
techknowlogick previously requested changes Jun 11, 2021
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking per conversation in discord.

6543
6543 commented Jun 14, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@bminer
Copy link
Contributor

bminer commented Jun 17, 2021 •
edited

Just want to ensure #15859 ends up in the Changelog (I saw #15758, but this PR will not work without the other one). Did #15859 get backported?

EDIT: Yes it got backported but the other PR # was not in the changelog. Not a big deal IMO.

@6543 6543 requested a review from techknowlogick June 18, 2021 13:33
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 18, 2021
zeripath
zeripath reviewed Jun 18, 2021
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
zeripath
zeripath reviewed Jun 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Jun 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
zeripath
zeripath reviewed Jun 18, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@techknowlogick techknowlogick dismissed their stale review June 18, 2021 14:42

dismiss my review

@6543 @zeripath
Apply suggestions from code review
fdfc64d 
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 merged commit 8cfd669 into go-gitea:release/v1.14 Jun 18, 2021
@6543 6543 deleted the changelog_v1.14.3 branch June 18, 2021 15:25
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 18, 2021
@6543 @lafriks @zeripath
Changelog v1.14.3 (go-gitea#16131)
4e8b326 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request Jun 18, 2021
Merged
@6543 6543 added frontport/done The frontport PR has been created frontport/main This PR is not targeting the main branch. Still, its changes should also be added there labels Jun 18, 2021
@6543
Copy link
Member Author

6543 commented Jun 18, 2021

-> #16196

techknowlogick pushed a commit that referenced this pull request Jun 18, 2021
@6543 @lafriks @zeripath
Changelog v1.14.3 (#16131) (#16196)
59f2558 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@6543 @lafriks
@zeripath @AbdulrhmnGhanem
Changelog v1.14.3 (go-gitea#16131) (go-gitea#16196)
839884b 
Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@khmarbaise khmarbaise khmarbaise approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

@zeripath zeripath zeripath approved these changes

@lafriks lafriks Awaiting requested review from lafriks

@techknowlogick techknowlogick Awaiting requested review from techknowlogick

Assignees
No one assigned
Labels
frontport/done The frontport PR has been created frontport/main This PR is not targeting the main branch. Still, its changes should also be added there lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.14.3
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@6543 @tomaswarynyca @bminer @khmarbaise @techknowlogick @KN4CK3R @zeripath @GiteaBot @lafriks