Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing discard in repo_language_stats #16030

Merged
merged 2 commits into from Jun 16, 2021
Merged

Fix missing discard in repo_language_stats #16030

merged 2 commits into from Jun 16, 2021

Conversation

zeripath
Copy link
Contributor

Set the missing discard(1) in repo_language_stats.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix missing discard in repo_language_stats
ae30cf4 
Set the missing discard(1) in repo_language_stats.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 30, 2021
@zeripath zeripath added this to the 1.15.0 milestone May 30, 2021
@zeripath
Copy link
Contributor Author

Happy to roll this in to #15891 if that looks like getting merged soon

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #16030 (ae30cf4) into main (effad26) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16030      +/-   ##
==========================================
- Coverage   44.08%   44.08%   -0.01%     
==========================================
  Files         682      682              
  Lines       82373    82370       -3     
==========================================
- Hits        36318    36310       -8     
- Misses      40149    40154       +5     
  Partials     5906     5906
Impacted Files Coverage Δ
modules/git/repo_language_stats_nogogit.go 48.75% <66.66%> (+4.17%) ⬆️
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 26.02% <0.00%> (-2.74%) ⬇️
modules/process/manager.go 72.83% <0.00%> (-2.47%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
modules/log/event.go 58.96% <0.00%> (-0.95%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
modules/queue/workerpool.go 56.48% <0.00%> (+2.67%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update effad26...ae30cf4. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 16, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2021
@techknowlogick techknowlogick merged commit 5f4522c into go-gitea:main Jun 16, 2021
@zeripath zeripath deleted the fix-missing-discard-in-stats branch June 16, 2021 22:17
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@zeripath @6543 @AbdulrhmnGhanem
Fix missing discard in repo_language_stats (go-gitea#16030)
7862105 
Set the missing discard(1) in repo_language_stats.

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: 6543 <6543@obermui.de>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeripath @codecov-commenter @techknowlogick @6543 @GiteaBot