Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't record error when loading ref comment but ref comment id is zero #15820

Merged
merged 2 commits into from
May 11, 2021
Merged

don't record error when loading ref comment but ref comment id is zero #15820

merged 2 commits into from
May 11, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented May 10, 2021

As title.

@lunny lunny added the type/enhancement An improvement of existing functionality label May 10, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 11, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 11, 2021
@zeripath
Copy link
Contributor

make lgtm work

@zeripath zeripath merged commit 143071e into go-gitea:main May 11, 2021
@lunny lunny deleted the lunny/silence_ref_zero_id branch May 12, 2021 05:41
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@lunny @AbdulrhmnGhanem
don't record error when loading ref comment but ref comment id is zero (
5913ee0 
go-gitea#15820)
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lunny @zeripath @silverwind @GiteaBot