Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DB session cleanup #15697

Merged
merged 2 commits into from
May 2, 2021
Merged

Fix DB session cleanup #15697

merged 2 commits into from
May 2, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 1, 2021

The DB session clean up needs to check expiry not created_unix.

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Fix DB session cleanup
e1c268a 
The DB session clean up needs to check expiry not created_unix.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.15.0 milestone May 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 1, 2021 •
edited

Codecov Report

Merging #15697 (8b0e72b) into master (a926ff9) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15697   +/-   ##
=======================================
  Coverage   43.90%   43.91%           
=======================================
  Files         678      678           
  Lines       81838    81838           
=======================================
+ Hits        35935    35936    +1     
  Misses      40053    40053           
+ Partials     5850     5849    -1
Impacted Files Coverage Δ
models/session.go 0.00% <0.00%> (ø)
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a926ff9...8b0e72b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 1, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 1, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2021
@techknowlogick techknowlogick merged commit 6ebd833 into go-gitea:master May 2, 2021
@zeripath zeripath deleted the fix-db-session-cleanup branch May 2, 2021 06:34
zeripath added a commit to zeripath/gitea that referenced this pull request May 2, 2021
@zeripath
Fix DB session cleanup (go-gitea#15697)
3041feb 
Backport go-gitea#15697

The DB session clean up needs to check expiry not created_unix.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request May 2, 2021
Merged
@zeripath zeripath added the backport/done All backports for this PR have been created label May 2, 2021
zeripath added a commit that referenced this pull request May 2, 2021
@zeripath
Fix DB session cleanup (#15697) (#15700)
3ce46a7 
Backport #15697

The DB session clean up needs to check expiry not created_unix.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zeripath @codecov-commenter @techknowlogick @6543 @GiteaBot