fix webhook timeout bug #15613
Merged
fix webhook timeout bug #15613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Apr 25, 2021
GiteaBot
added
the
lgtm/need 1
lafriks
approved these changes
Apr 25, 2021
GiteaBot
added
lgtm/done
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Apr 26, 2021
* Also fix the potential problem in httplib
6543
pushed a commit
that referenced
this pull request
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conn.SetDeadlinewill set a timeout based on connection succeed but not per request. Since a connection maybe resued for multiple http requests. This will result in many timeout on webhook requests.This PR fix the problem which also found in gitea.com
This PR also changed a similiar problem on
httplib. Because it will always create a new client when request, so it will not be affected currently. But creating a new client per request is really a problem should be fixed.