Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add size to Save function #15264

Merged
merged 3 commits into from Apr 3, 2021
Merged

Add size to Save function #15264

merged 3 commits into from Apr 3, 2021

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 3, 2021

This PR proposes an alternative solution to #15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close #15255
Fix #15253

Signed-off-by: Andrew Thornton art27@cantab.net

@zeripath
Alternative to go-gitea#15255 - add size to Save function
89fb6d0 
This PR proposes an alternative solution to go-gitea#15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close go-gitea#15255
Fix go-gitea#15253

Signed-off-by: Andrew Thornton <art27@cantab.net>
@lunny
Copy link
Member

lunny commented Apr 3, 2021

We need some comment to say the size could be -1.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 3, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2021
@lunny lunny added backport/v1.13 performance/memory Performance issues affecting memory use labels Apr 3, 2021
@lunny lunny added this to the 1.15.0 milestone Apr 3, 2021
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Apr 3, 2021
@6543 6543 changed the title Alternative to #15255 - add size to Save function Add size to Save function Apr 3, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 3, 2021
@6543
Copy link
Member

6543 commented Apr 3, 2021

🚀

@6543 6543 merged commit 0bb8bd8 into go-gitea:master Apr 3, 2021
@lunny
Copy link
Member

lunny commented Apr 3, 2021

Maybe we can wait for adding PartSize to PutObjectOptions before send back port.

@zeripath zeripath deleted the alternative-to-15255 branch April 3, 2021 19:50
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 3, 2021
@zeripath
Add size to Save function (go-gitea#15264)
15700b3 
This PR proposes an alternative solution to go-gitea#15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close go-gitea#15255
Fix go-gitea#15253

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Apr 3, 2021
Merged
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 3, 2021
@zeripath
Add size to Save function (go-gitea#15264)
af941b4 
Backport go-gitea#15264

This PR proposes an alternative solution to go-gitea#15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close go-gitea#15255
Fix go-gitea#15253

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this pull request Apr 3, 2021
Merged
@zeripath
Copy link
Contributor Author

zeripath commented Apr 3, 2021

@lunny I don't understand - do you have a PR for that?

techknowlogick pushed a commit that referenced this pull request Apr 4, 2021
@zeripath
Add size to Save function (#15264) (#15271)
013639b 
Backport #15264

This PR proposes an alternative solution to #15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close #15255
Fix #15253

Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick pushed a commit that referenced this pull request Apr 4, 2021
@zeripath @lunny
Add size to Save function (#15264) (#15270)
af73e1e 
This PR proposes an alternative solution to #15255 - just add the size to the
save function. Yes it is less apparently clean but it may be more correct.

Close #15255
Fix #15253

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@lunny
Copy link
Member

lunny commented Apr 5, 2021

When -1 is given, minio sdk will spend max 5G memory if partSize given 0. So I think we could also give a fixed partSize even size is -1.

@6543 6543 added backport/done All backports for this PR have been created and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Apr 7, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/memory Performance issues affecting memory use
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

git LFS and storage type minio: Massive memory usage
4 participants
@zeripath @lunny @6543 @GiteaBot