Never add labels not from this repository or organisation and remove org labels on transfer

[zeripath]

Prevent the addition of labels from outside of the repository or
organisation and remove organisation labels on transfer.

Related #14908
Related #14912

Signed-off-by: Andrew Thornton art27@cantab.net

[zeripath]

This is an extract from #14912 without the broken migration and consistency check - which should be fixed in that or another PR.

[zeripath]

Damn! This still has the broken query.

[zeripath]

finally fixed the damned SQL!

[lunny]

How about to create a new function named

(i *Issue) CanAddLabel(l *Label) bool {
     switch {
        case l.RepoID > 0:
           return l.RepoID == issue.RepoID
        case l.OrgID > 0:
           return l.OrgID == issue.Owner.ID
        default:
           return false
     }
}

[zeripath]

That's not going to improve the complexity of repo_transfer.go.

It would also have to be:

func (issue *Issue) isValidLabel(e Engine, label *Label) (bool, error) {
	if err := issue.loadRepo(e); err != nil {
		return false, err
	}

	return (label.RepoID == issue.RepoID || label.OrgID == issue.Repo.OwnerID), nil
}

// IsValidLabel returns true if the label is a valid label for this issue.
func (issue *Issue) IsValidLabel(label *Label) (bool, error) {
	return issue.isValidLabel(x, label)
}

i.e. it would have to return an error which would significantly increase the complexity of ReplaceLabels and newIssueLabels

[zeripath]

We can't check hasLabel in there because it would still require duplication in the code for replace labels.

[zeripath]

Aha the test failure was a real failure - the others were passing in error!

[6543]

🚀