Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Bleve and Elastic code indexers to use a common cat-file --batch #14781

Merged
merged 9 commits into from Mar 4, 2021

Conversation

zeripath
Copy link
Contributor

Both bleve and elastic code indexers will call cat-file blob blobsha repeatedly for each file indexed. By using a single cat-file --batch we can reduce these multiple calls to a single common cat-file batch.

Signed-off-by: Andrew Thornton art27@cantab.net

Signed-off-by: Andrew Thornton <art27@cantab.net>
… indexing

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added the type/enhancement An improvement of existing functionality label Feb 23, 2021
@6543 6543 added this to the 1.14.0 milestone Feb 26, 2021
@6543 6543 added performance/memory Performance issues affecting memory use performance/speed performance issues with slow downs labels Feb 27, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 27, 2021
@codecov-io
Copy link

Codecov Report

Merging #14781 (b10ab24) into master (487f2ee) will decrease coverage by 0.01%.
The diff coverage is 38.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14781      +/-   ##
==========================================
- Coverage   42.21%   42.20%   -0.02%     
==========================================
  Files         767      771       +4     
  Lines       81624    82093     +469     
==========================================
+ Hits        34458    34646     +188     
- Misses      41531    41800     +269     
- Partials     5635     5647      +12     
Impacted Files Coverage Δ
models/action.go 48.52% <0.00%> (-2.42%) ⬇️
models/migrations/migrations.go 2.59% <ø> (ø)
models/migrations/v166.go 0.00% <0.00%> (ø)
models/migrations/v172.go 0.00% <0.00%> (ø)
models/migrations/v173.go 0.00% <0.00%> (ø)
models/oauth2.go 29.16% <0.00%> (-2.66%) ⬇️
models/session.go 0.00% <0.00%> (ø)
models/user.go 53.05% <ø> (+0.38%) ⬆️
modules/context/context.go 65.22% <0.00%> (+6.72%) ⬆️
modules/git/pipeline/lfs_nogogit.go 0.00% <0.00%> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42118c6...b10ab24. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 523efa4 into go-gitea:master Mar 4, 2021
@zeripath zeripath deleted the batch-cat-files-in-index branch March 4, 2021 07:41
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. performance/memory Performance issues affecting memory use performance/speed performance issues with slow downs type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants