Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend TestUserOrgs to cover permission cases #14495

Merged
merged 6 commits into from
Jan 28, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 27, 2021

Add test for #13868 bug

@6543 6543 added this to the 1.14.0 milestone Jan 27, 2021
@6543 6543 added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 27, 2021
@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #14495 (cd8ac3d) into master (41c0776) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14495   +/-   ##
=======================================
  Coverage   42.09%   42.09%           
=======================================
  Files         758      758           
  Lines       81106    81106           
=======================================
+ Hits        34139    34145    +6     
+ Misses      41386    41381    -5     
+ Partials     5581     5580    -1     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 56.00% <0.00%> (-12.00%) ⬇️
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
modules/git/repo_commit_nogogit.go 63.33% <0.00%> (-1.67%) ⬇️
models/error.go 39.96% <0.00%> (+0.48%) ⬆️
models/repo_list.go 78.76% <0.00%> (+0.88%) ⬆️
services/pull/check.go 50.73% <0.00%> (+2.20%) ⬆️
models/unit.go 49.31% <0.00%> (+2.73%) ⬆️
routers/api/v1/utils/utils.go 64.10% <0.00%> (+5.12%) ⬆️
modules/git/tree_entry_nogogit.go 93.75% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe5266a...5b8cefd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 27, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2021
@6543 6543 merged commit 3599d44 into go-gitea:master Jan 28, 2021
@6543 6543 deleted the add-test-for-13868-bug branch January 28, 2021 21:40
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants