Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dashboard issues labels filter bug #14210

Merged
merged 3 commits into from
Jan 1, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 1, 2021

Fix #14084

@lunny lunny added this to the 1.14.0 milestone Jan 1, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 1, 2021
@codecov-io
Copy link

codecov-io commented Jan 1, 2021

Codecov Report

Merging #14210 (c51509f) into master (a07e67d) will increase coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14210   +/-   ##
=======================================
  Coverage   42.00%   42.00%           
=======================================
  Files         734      734           
  Lines       78770    78780   +10     
=======================================
+ Hits        33088    33095    +7     
- Misses      40246    40247    +1     
- Partials     5436     5438    +2     
Impacted Files Coverage Δ
models/issue.go 57.05% <83.33%> (-0.04%) ⬇️
routers/user/home.go 60.58% <100.00%> (+0.31%) ⬆️
modules/indexer/stats/queue.go 64.70% <0.00%> (-11.77%) ⬇️
modules/indexer/stats/db.go 40.00% <0.00%> (-8.00%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
modules/log/event.go 59.90% <0.00%> (-0.95%) ⬇️
services/pull/check.go 48.52% <0.00%> (-0.74%) ⬇️
models/error.go 38.49% <0.00%> (-0.49%) ⬇️
services/pull/pull.go 42.85% <0.00%> (+0.50%) ⬆️
routers/repo/view.go 38.24% <0.00%> (+0.64%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a07e67d...c51509f. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 1, 2021
@techknowlogick techknowlogick merged commit 21adeaa into go-gitea:master Jan 1, 2021
@techknowlogick
Copy link
Member

@lunny please backport :)

@lunny lunny deleted the lunny/fix_issues_labels branch January 2, 2021 01:53
lunny added a commit to lunny/gitea that referenced this pull request Jan 2, 2021
Co-authored-by: zeripath <art27@cantab.net>
@lunny lunny added the backport/done All backports for this PR have been created label Jan 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering issues by label doesn't work with paging
6 participants