Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MirrorInterval to the API #14163

Merged
merged 14 commits into from
Jan 2, 2021
Merged

Add MirrorInterval to the API #14163

merged 14 commits into from
Jan 2, 2021

Conversation

paulbarton90
Copy link
Contributor

This should address #11605. Allows you to create a migration setting the value, and edit it after the fact.

@codecov-io
Copy link

codecov-io commented Dec 27, 2020 •
edited

Codecov Report

Merging #14163 (658da8d) into master (cf9d471) will decrease coverage by 0.36%.
The diff coverage is 6.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14163      +/-   ##
==========================================
- Coverage   42.36%   42.00%   -0.37%     
==========================================
  Files         728      733       +5     
  Lines       78015    78756     +741     
==========================================
+ Hits        33049    33079      +30     
- Misses      39540    40239     +699     
- Partials     5426     5438      +12
Impacted Files Coverage Δ
cmd/dump_repo.go 0.00% <0.00%> (ø)
cmd/restore_repo.go 0.00% <0.00%> (ø)
models/action.go 50.93% <0.00%> (-1.98%) ⬇️
models/admin.go 60.31% <0.00%> (-8.78%) ⬇️
models/repo.go 52.15% <ø> (+0.25%) ⬆️
models/repo_list.go 78.76% <0.00%> (-0.71%) ⬇️
models/task.go 34.95% <ø> (+0.04%) ⬆️
modules/auth/repo_form.go 39.83% <ø> (ø)
modules/migrations/base/downloader.go 17.51% <ø> (ø)
modules/migrations/base/pullrequest.go 0.00% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ca44c...658da8d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 27, 2020
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Dec 28, 2020
6543
6543 reviewed Dec 28, 2020
View reviewed changes
modules/structs/repo.go Outdated Show resolved Hide resolved
6543
6543 requested changes Dec 28, 2020
View reviewed changes
models/repo.go Outdated Show resolved Hide resolved
6543
6543 reviewed Dec 28, 2020
View reviewed changes
routers/api/v1/repo/repo.go Outdated Show resolved Hide resolved
6543
6543 reviewed Dec 28, 2020
View reviewed changes
routers/api/v1/repo/repo.go Outdated Show resolved Hide resolved
paulbarton90 and others added 2 commits December 30, 2020 22:07
@paulbarton90 @zeripath
Frequency Error Message
658da8d 
Co-authored-by: zeripath <art27@cantab.net>
@paulbarton90
Allow Zero Mirror Interval
bbc99f1
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 1, 2021
@zeripath zeripath requested a review from 6543 January 1, 2021 15:36
@zeripath
Copy link
Contributor

zeripath commented Jan 1, 2021

@6543 Please could you re-review.

6543
6543 approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jup

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2021
@zeripath zeripath added this to the 1.14.0 milestone Jan 2, 2021
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit 7576e37 into go-gitea:master Jan 2, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@paulbarton90 @codecov-io @zeripath @techknowlogick @6543 @GiteaBot