Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize Co-Authored-By / Reviewed-By strings #14097

Merged
merged 3 commits into from Dec 22, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Dec 21, 2020

Make sure all these strings use same capitalization style.

  • Co-Authored-By -> Co-authored-by
  • Reviewed-By -> Reviewed-by

@CirnoT
Copy link
Contributor Author

CirnoT commented Dec 21, 2020

On unrelated note, we should perform check against noreply email to avoid situation where Co-Authored-By is inserted twice for same user, once from commits with email exposed and once with noreply variant when merging from UI (if user selected to hide email)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2020
@codecov-io
Copy link

codecov-io commented Dec 21, 2020

Codecov Report

Merging #14097 (7949fce) into master (acd5e5a) will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14097      +/-   ##
==========================================
+ Coverage   42.33%   42.35%   +0.01%     
==========================================
  Files         726      726              
  Lines       77799    77799              
==========================================
+ Hits        32940    32950      +10     
+ Misses      39445    39443       -2     
+ Partials     5414     5406       -8     
Impacted Files Coverage Δ
modules/repofiles/temp_repo.go 59.65% <0.00%> (ø)
services/pull/merge.go 49.18% <100.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/indexer/code/elastic_search.go 0.00% <0.00%> (-1.77%) ⬇️
services/pull/pull.go 42.85% <0.00%> (+0.50%) ⬆️
modules/queue/unique_queue_disk_channel.go 55.38% <0.00%> (+1.53%) ⬆️
modules/log/file.go 75.20% <0.00%> (+1.60%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/git/utils.go 80.55% <0.00%> (+2.77%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd5e5a...7949fce. Read the comment docs.

@lunny lunny added the type/docs This PR mainly updates/creates documentation label Dec 21, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2020
@lunny
Copy link
Member

lunny commented Dec 21, 2020

But it seems Github use Co-authored-by but not Co-Authored-By.

@CirnoT
Copy link
Contributor Author

CirnoT commented Dec 21, 2020

There seems to be both usages happening in the wild. Either one is fine with me, so long it's consistent across all places.

@silverwind
Copy link
Member

Seems the lowercase variant is more common as far as git itself is concerned:

https://github.com/git/git/search?q=Reviewed-By&type=code

@CirnoT
Copy link
Contributor Author

CirnoT commented Dec 22, 2020

Switched to lowercase variant

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 22, 2020
@techknowlogick techknowlogick merged commit 2c9dd71 into go-gitea:master Dec 22, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Dec 22, 2020
@techknowlogick techknowlogick added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 22, 2020
@CirnoT CirnoT deleted the reviewed branch December 22, 2020 17:28
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants