Remove User.GetOrganizations()

[6543]

followup of #13994

[zeripath]

I can't point to a definite place where this will be wrong but I am certain that this will get the NumRepos incorrect in cases where a user cannot see all of the repositories of an organisation.

[zeripath]

gitea/models/org.go

Lines 390 to 408 in 8af9df0

	func getOrgsByUserID(sess *xorm.Session, userID int64, showAll bool) ([]*User, error) {
	orgs := make([]*User, 0, 10)
	if !showAll {
	sess.And("`org_user`.is_public=?", true)
	}
	return orgs, sess.
	And("`org_user`.uid=?", userID).
	Join("INNER", "`org_user`", "`org_user`.org_id=`user`.id").
	Asc("`user`.name").
	Find(&orgs)
	}
	// GetOrgsByUserID returns a list of organizations that the given user ID
	// has joined.
	func GetOrgsByUserID(userID int64, showAll bool) ([]*User, error) {
	sess := x.NewSession()
	defer sess.Close()
	return getOrgsByUserID(sess, userID, showAll)
	}

does not account for the num repos that are accessible to the user.

gitea/models/user.go

Lines 557 to 587 in 8af9df0

	sess.Select("`user`.*, count(repo_id) as org_count").
	Table("user").
	Join("INNER", "org_user", "`org_user`.org_id=`user`.id").
	Join("LEFT", builder.
	Select("id as repo_id, owner_id as repo_owner_id").
	From("repository").
	Where(accessibleRepositoryCondition(u)), "`repository`.repo_owner_id = `org_user`.org_id").
	And("`org_user`.uid=?", u.ID).
	GroupBy(groupByStr)
	if opts.PageSize != 0 {
	sess = opts.setSessionPagination(sess)
	}
	type OrgCount struct {
	User `xorm:"extends"`
	OrgCount int
	}
	orgCounts := make([]*OrgCount, 0, 10)
	if err := sess.
	Asc("`user`.name").
	Find(&orgCounts); err != nil {
	return err
	}
	orgs := make([]*User, len(orgCounts))
	for i, orgCount := range orgCounts {
	orgCount.User.NumRepos = orgCount.OrgCount
	orgs[i] = &orgCount.User
	}
	u.Orgs = orgs

Checks how many repositories are accessible to the user along with the organizations. An organization should only be shown if there is a repository accessible to the user as far as I can see.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@e4567d4). Click here to learn what that means.
The diff coverage is 50.00%.

@@            Coverage Diff            @@
##             master   #14032   +/-   ##
=========================================
  Coverage          ?   42.20%           
=========================================
  Files             ?      725           
  Lines             ?    77623           
  Branches          ?        0           
=========================================
  Hits              ?    32759           
  Misses            ?    39497           
  Partials          ?     5367           

Impacted Files	Coverage Δ
models/user.go	53.01% <ø> (ø)
routers/user/home.go	60.67% <50.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4567d4...8da074f. Read the comment docs.

[6543]

hmm we should fix getOrgsByUserID then ...

[lunny]

Is this ready to review?

[6543]

@lunny sadly no: ...getOrgsByUserID() does not account for the num repos that are accessible to the user...

[6543]

@techknowlogick since latest refactors we can savely remove it cc @zeripath

out of date

[6543]

🚀