Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause NotifyMigrateRepository to emit a repo create webhook #14004

Merged
merged 3 commits into from
Dec 17, 2020

Conversation

zeripath
Copy link
Contributor

This PR simply makes NotifyMigrateRepository emit a Create Repo webhook.
The reason for no new payload is that the information sent to
NotifyMigrateRepository is only essentially the same as
NotifyCreateRepository

Fix #13996

Signed-off-by: Andrew Thornton art27@cantab.net

This PR simply makes NotifyMigrateRepository emit a Create Repo webhook.
The reason for no new payload is that the information sent to
NotifyMigrateRepository is only essentially the same as
NotifyCreateRepository

Fix go-gitea#13996

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added this to the 1.14.0 milestone Dec 15, 2020
@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #14004 (202a5bf) into master (80a299d) will increase coverage by 0.12%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14004      +/-   ##
==========================================
+ Coverage   42.09%   42.22%   +0.12%     
==========================================
  Files         710      710              
  Lines       77307    77315       +8     
==========================================
+ Hits        32544    32646     +102     
+ Misses      39408    39300     -108     
- Partials     5355     5369      +14     
Impacted Files Coverage Δ
modules/notification/webhook/webhook.go 49.65% <75.00%> (+0.35%) ⬆️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/log/event.go 59.90% <0.00%> (-0.95%) ⬇️
routers/repo/view.go 37.47% <0.00%> (-0.65%) ⬇️
services/pull/pull.go 40.68% <0.00%> (ø)
models/error.go 39.31% <0.00%> (+0.81%) ⬆️
models/notification.go 67.24% <0.00%> (+0.98%) ⬆️
modules/queue/workerpool.go 60.81% <0.00%> (+2.04%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.18%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a299d...202a5bf. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 15, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 16, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2020
@6543 6543 merged commit 0851a89 into go-gitea:master Dec 17, 2020
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Dec 17, 2020
…#14004)

* Cause NotifyMigrateRepository to emit a repo create webhook

This PR simply makes NotifyMigrateRepository emit a Create Repo webhook.
The reason for no new payload is that the information sent to
NotifyMigrateRepository is only essentially the same as
NotifyCreateRepository

Fix go-gitea#13996

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath deleted the fix-13996-webhook-migration branch December 17, 2020 18:20
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
@6543 6543 added the type/bug label Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/webhooks type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No system webhook triggered for repository migration
5 participants