Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace more icons with SVG, repo search tweaks #13860

Merged
merged 6 commits into from
Dec 9, 2020
Merged

Replace more icons with SVG, repo search tweaks #13860

merged 6 commits into from
Dec 9, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Dec 5, 2020 •
edited

  • Replace remaining icons on admin page with SVG
  • Fix vertical menu background on arc-green
  • Minor improvements to frontpage repo search
  • Improve webhooks list
  • More icon replacements here and there
  • Dropdown color fixes for arc-green

Screen Shot 2020-12-05 at 16 11 03

Screen Shot 2020-12-05 at 16 24 17

image

Screen Shot 2020-12-05 at 16 48 14

Screen Shot 2020-12-05 at 15 57 14

Screen Shot 2020-12-05 at 15 23 27

Screen Shot 2020-12-05 at 14 53 23

Screen Shot 2020-12-05 at 15 06 49

@silverwind silverwind added type/refactoring Existing code has been cleaned up. There should be no new functionality. topic/ui Change the appearance of the Gitea UI skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Dec 5, 2020
@silverwind silverwind added this to the 1.14.0 milestone Dec 5, 2020
@6543
Copy link
Member

6543 commented Dec 6, 2020

ping

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 6, 2020
@silverwind silverwind mentioned this pull request Dec 7, 2020
Closed
@silverwind
Replace more icons with SVG
9f393c3 
- Replace remaining icons on admin page with SVG
- Fix vertical menu background on arc-green
- Minor improvments to frontpage repo search
- More icon replacements here and there
@silverwind
fix integration
97e232f
@silverwind
whitespace tweak
ac1ed53
@silverwind
add comment
61819ba
@silverwind
Copy link
Member Author

Rebased and a comment added.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 8, 2020
@silverwind silverwind changed the title Replace more icons with SVG Replace more icons with SVG, repo search tweaks Dec 9, 2020
@silverwind
Copy link
Member Author

silverwind commented Dec 9, 2020 •
edited

Description updated to mention everything this includes like repo search and dropdown fixes for arc-green.

@silverwind
Copy link
Member Author

Maybe I'll swap the icons back to unchecked/checked checkboxes which I like more then check/cross personally. Would be individual SVG files instead of from the icon font.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 9, 2020
@techknowlogick
Copy link
Member

Maybe I'll swap the icons back to unchecked/checked checkboxes which I like more then check/cross personally. Would be individual SVG files instead of from the icon font.

I have no preference, but I'll block this PR for you in case you do want to make this change.

@techknowlogick techknowlogick added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Dec 9, 2020
@silverwind
Copy link
Member Author

silverwind commented Dec 9, 2020 •
edited

I'll decide soon. It also depends whether I can find a suitable set of icons. I kind of like this one from the Feather set:

image

image

https://icomoon.io/app/#/select

@silverwind
Copy link
Member Author

I'll unblock this, it's ready to go. I'll keep cross/check icons on the notion that a cross is a better icon for "no" then a empty box which could be misinterpreted when seen alone.

@silverwind silverwind removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Dec 9, 2020
@techknowlogick
Copy link
Member

🚀

@techknowlogick techknowlogick merged commit c85bb62 into go-gitea:master Dec 9, 2020
@silverwind silverwind deleted the moresvg branch December 9, 2020 19:27
WeebDataHoarder added a commit to WeebDataHoarder/gitea that referenced this pull request Dec 13, 2020
@WeebDataHoarder
Removes dangling < on emails/list.tmpl
35a36c8 
This dangling character was leftover from commit c85bb62 from PR go-gitea#13860
@WeebDataHoarder WeebDataHoarder mentioned this pull request Dec 13, 2020
Merged
lunny pushed a commit that referenced this pull request Dec 13, 2020
@WeebDataHoarder
Removes dangling < on emails/list.tmpl (#13970)
de0986d 
This dangling character was leftover from commit c85bb62 from PR #13860
@CirnoT CirnoT mentioned this pull request Dec 15, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@silverwind @6543 @techknowlogick @GiteaBot