Update docker ssh passthrough docs #13732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13732 +/- ##
=======================================
Coverage 42.15% 42.15%
=======================================
Files 708 708
Lines 77123 77123
=======================================
+ Hits 32510 32515 +5
+ Misses 39269 39265 -4
+ Partials 5344 5343 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
| ``` | ||
| ln -s /var/lib/gitea/git/.ssh/authorized_keys /home/git/.ssh/authorized_keys | ||
| ```bash | ||
| ssh -p 2222 -o StrictHostKeyChecking=no [git@127.0.0.1](mailto:git@127.0.0.1) "SSH_ORIGINAL_COMMAND=\"$SSH_ORIGINAL_COMMAND\" $0 $@" |
There was a problem hiding this comment.
I think this mailto may have snuck in unintentionally.
There was a problem hiding this comment.
Feel free to remove it - I just used what Gitea already uses in this place.
|
Thanks for this PR, @pat-s, it helped me get ssh passthrough working :) |
techknowlogick
approved these changes
Dec 2, 2020
GiteaBot
added
lgtm/need 1
zeripath
approved these changes
Dec 2, 2020
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Discord with @zeripath, a major rewrite and simplification of the docker SSH passthrough docs.
Changelog summary
.ssh/authorized_keys→ confusing and unstable due toSSH_AUTHORIZED_KEYS_BACKUPoptionRelated issues
I am not sure if PR #12626 is valid or not - for me it worked with the current setup on the latest dev version. But this is not necessarliy important for this PR.