Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tooltips and issue dependency styles #13458

Merged
merged 1 commit into from Nov 10, 2020
Merged

Fix tooltips and issue dependency styles #13458

merged 1 commit into from Nov 10, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 7, 2020 •
edited

  • Convert all CSS tooltips to JS-based ones, fixing overflow issues
  • Restyle issue dependencies/dependants
  • Move popup styles to base style
  • CSS Helper tweaks
  • Unify pseudo element selectors and lint for it

Fixes: #13400

Screen Shot 2020-11-07 at 16 32 09

image

Screen Shot 2020-11-07 at 17 43 01

Screen Shot 2020-11-07 at 17 43 29

@silverwind silverwind force-pushed the tooltips branch 5 times, most recently from e2e29ca to 3a1a533 Compare November 7, 2020 18:11
@lafriks
Copy link
Member

lafriks commented Nov 7, 2020

Please resolve conflicts

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2020
@lafriks lafriks modified the milestone: Ui Nov 7, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 7, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 7, 2020
@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Nov 7, 2020
@silverwind
Copy link
Member Author

Rebased and screenshots updated.

@silverwind
Copy link
Member Author

@lafriks converted to double-colon syntax and changed linting for it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2020
@6543
Copy link
Member

6543 commented Nov 9, 2020

@silverwind it's conflicting again

@lafriks
Copy link
Member

lafriks commented Nov 10, 2020

I would say that column count should not be changed because it could have undesirable effect. Generally I think single : is better because it does not create additional pseido elements in DOM but if we remove them it could effect spacing etc especially where we have content: ' ' in css. So imho for now this rune should be disabled and column usage : or :: should be reviewed in other PR

@silverwind
Copy link
Member Author

silverwind commented Nov 10, 2020 •
edited

I don't think there is any practical difference between ::before vs :before. I've been using them interchangeable for a long time and I think it's purely a stylistic thing. One could argue : saves a few bytes and I generally prefer the single colon syntax because I don't want to think whether something is a pseudo element or a pseudo selector. Yes, I can remove these changes for now.

@lafriks
Copy link
Member

lafriks commented Nov 10, 2020

On second thought I don't mind having :: in this PR, so leave at it is now

@silverwind
Fix tooltips and issue dependency styles
5129268 
- Convert all tooltips to JS-based ones, fixing overflow issues
- Restyle issue dependencies/dependants
- Move popup styles to base style
- CSS Helper tweaks
- Unify pseudo element selectors and lint for it

Fixes: go-gitea#13400
@silverwind
Copy link
Member Author

Rebased and squashed.

@GiteaBot GiteaBot removed the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 10, 2020
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 10, 2020
@lafriks lafriks merged commit 21d4963 into go-gitea:master Nov 10, 2020
@silverwind silverwind deleted the tooltips branch November 10, 2020 18:36
@silverwind silverwind mentioned this pull request Nov 13, 2020
Merged
silverwind added a commit to silverwind/gitea that referenced this pull request Nov 13, 2020
@silverwind
Fix issue label spacing and hover
5631051 
Fixes: go-gitea#13545
Regressed by: go-gitea#13458
techknowlogick pushed a commit that referenced this pull request Nov 14, 2020
@silverwind
Fix issue label spacing and hover (#13553)
5c76c5c 
Fixes: #13545
Regressed by: #13458
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Tooltips go out of the screen
5 participants
@silverwind @lafriks @6543 @zeripath @GiteaBot