Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken table layout #1344

Merged
merged 1 commit into from Mar 21, 2017
Merged

Fix broken table layout #1344

merged 1 commit into from Mar 21, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Mar 20, 2017

The table layout in the README is broken after Github's change of markdown renderer. This PR will fix that and display the screenshots in a 3x3 table.
Github markdown doesn't support tables without headers so there's an empty row at the top.
Looks ok in Gitea too, https://try.gitea.io/cez81/gitea/src/fix_readme_layout/README.md.

References:
https://github.com/blog/2333-a-formal-spec-for-github-flavored-markdown
github/markup#1010 (comment)

@lunny lunny added this to the 1.2.0 milestone Mar 21, 2017
@lunny lunny added the type/bug label Mar 21, 2017
@lunny
Copy link
Member

lunny commented Mar 21, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 21, 2017
@ethantkoenig
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2017
@lunny lunny merged commit 9a9f8fa into go-gitea:master Mar 21, 2017
@cez81 cez81 deleted the fix_readme_layout branch March 21, 2017 10:14
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants