Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto-tag to false on rootless manifest #13383

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Conversation

techknowlogick
Copy link
Member

Currently rootless overrides rootful image (latest). I've also moved rootless manifest to occur before rootful just in case as well.

This is a temp fix as I am about to head to bed and don't want to wake up to many people reporting issues who auto-update on latest. We can look into correct behaviour later.

Current overrides rootful container
@techknowlogick techknowlogick added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Nov 1, 2020
@techknowlogick techknowlogick added this to the 1.14.0 milestone Nov 1, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 1, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 1, 2020
@codecov-io
Copy link

Codecov Report

Merging #13383 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13383      +/-   ##
==========================================
- Coverage   42.14%   42.13%   -0.02%     
==========================================
  Files         691      691              
  Lines       75966    75966              
==========================================
- Hits        32019    32005      -14     
- Misses      38703    38712       +9     
- Partials     5244     5249       +5     
Impacted Files Coverage Δ
modules/indexer/stats/db.go 52.17% <0.00%> (-8.70%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/utils.go 73.77% <0.00%> (-3.28%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
modules/git/repo.go 46.19% <0.00%> (-0.51%) ⬇️
services/pull/pull.go 40.78% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f070249...d79ae80. Read the comment docs.

@zeripath zeripath merged commit 543697e into master Nov 1, 2020
@techknowlogick techknowlogick deleted the techknowlogick-patch-1 branch November 1, 2020 20:03
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants